Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix makefile to not spam releases for feature/dynamodbstreams/attributevalue #2885

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

lucix-aws
Copy link
Contributor

@lucix-aws lucix-aws commented Nov 1, 2024

We've been spamming feature/dynamodbstreams/attributevalue releases, this fixes that.

why

feature/dynamodbstreams is copied from feature/dynamodb as part of make recipe copy-attributevalue-feature - so whenever you update one, you technically also update the other. This happens on release.

That includes the go_module_metadata.go file from the source module. At some point in the past few months the committed versions for these two files got desynced. So every release, this has been happening:

  • release runs make generate - nothing changes in the streams version except for go_module_metadata.go
  • release system goes "hey, contents of feature/dynamodbstreams/attributevalue changed - new release!"
  • release annotation runs, updating tags and module versions - which upon seeing no changelog entry in ddb streams, just does the default patch version bump, inserting a dummy changelog that says "no notes"
    • that process involves setting the value in go_module_metadata.go to the new version. so the incidental copy, which triggered this whole thing in the first place, is overwritten. rinse and repeat

testing

Tested by running make generate with:

  • nothing changed in dynamodb/attributevalue. verified that the module metadata file stream-side didn't update this time.
  • some dummy change in dynamodb/attributevalue. verified that it still gets copied

@lucix-aws lucix-aws requested a review from a team as a code owner November 1, 2024 16:14
@Madrigal
Copy link
Contributor

Madrigal commented Nov 1, 2024

Is it also a valid use case to update feature/dynamodbstreams independently and ensure the metadata gets updated?

@lucix-aws
Copy link
Contributor Author

No - it should be a direct clone of the main one.

@lucix-aws lucix-aws merged commit aa3bd1f into main Nov 1, 2024
13 checks passed
@lucix-aws lucix-aws deleted the fix-copyattributevalue branch November 1, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants